Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlapping seek bar and softkeys #7339

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Fix overlapping seek bar and softkeys #7339

merged 1 commit into from
Nov 18, 2020

Conversation

tobiasKaminsky
Copy link
Member

Fix #7305
Fix #7323

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@tobiasKaminsky
Fix overlapping seek bar and softkeys
aa28d30 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
This was referenced Nov 17, 2020
Closed
Closed
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/7339.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16772-Screenshot-master-light-blue

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings307307
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings41
Dodgy code Warnings102
Total313

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings53
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings41
Dodgy code Warnings102
Total313

@nextcloud-android-bot
Copy link
Collaborator

stable-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16772-Screenshot-stable-light-blue

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16772-IT-master

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16772-IT-stable

@nextcloud-android-bot
Copy link
Collaborator

master-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16772-Screenshot-master-dark-blue

@nextcloud-android-bot
Copy link
Collaborator

stable-dark-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16772-Screenshot-stable-dark-blue

@tobiasKaminsky tobiasKaminsky mentioned this pull request Nov 18, 2020
Closed
@AndyScherzinger
Copy link
Member

/backport to stable-3.14

@AndyScherzinger AndyScherzinger merged commit f87bd9b into master Nov 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the mediaOverlaps branch November 18, 2020 16:28
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 18, 2020
Merged
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.15.0 milestone Nov 18, 2020
@tobiasKaminsky tobiasKaminsky mentioned this pull request Nov 19, 2020
Closed
thelittlefireman pushed a commit to thelittlefireman/android that referenced this pull request Mar 19, 2021
@AndyScherzinger
Merge pull request nextcloud#7339 from nextcloud/mediaOverlaps
6b3e015 
Fix overlapping seek bar and softkeys
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.15.0
Development

Successfully merging this pull request may close these issues.

Confusing UI when playing a video file / audio file Seek bar and Softkey was overlap
3 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger